Fix mac dump_syms after r1163.

Fix mac dump_syms after r1163.

R=mark@chromium.org

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1175

[Lei Zhang (chromium)]

Whoops, I was running ./configure && make on mac, and that didn't build the mac
stuff.

I had to change src/common/mac/Breakpad.xcconfig:

SDKROOT = macosx10.7
GCC_VERSION = com.apple.compilers.llvm.clang.1_0

and run:

xcodebuild -project src/tools/mac/dump_syms/dump_syms.xcodeproj

to make sure mac dump_syms builds. Maybe I need to run against other .xcodeproj
files to make sure everything builds?

[Mark Mentovai]

LGTM

https://breakpad.appspot.com/592002/diff/2001/src/common/mac/dump_syms.mm
File src/common/mac/dump_syms.mm (right):

https://breakpad.appspot.com/592002/diff/2001/src/common/mac/dump_syms.mm#new...
src/common/mac/dump_syms.mm:400: 
Extra blank line nit.

[Lei Zhang (chromium)]

https://breakpad.appspot.com/592002/diff/2001/src/common/mac/dump_syms.mm
File src/common/mac/dump_syms.mm (right):

https://breakpad.appspot.com/592002/diff/2001/src/common/mac/dump_syms.mm#new...
src/common/mac/dump_syms.mm:400: 
On 2013/05/08 13:10:16, Mark Mentovai wrote:
> Extra blank line nit.

Done.

[Lei Zhang (chromium)]

Committed patchset #2 manually as r1175 (presubmit successful).

[icodestuff]

On 2013/05/08 04:25:12, thestig wrote:
> Whoops, I was running ./configure && make on mac, and that didn't build the
mac
> stuff.
> 
> I had to change src/common/mac/Breakpad.xcconfig:
> 
> SDKROOT = macosx10.7
> GCC_VERSION = com.apple.compilers.llvm.clang.1_0
> 
> and run:
> 
> xcodebuild -project src/tools/mac/dump_syms/dump_syms.xcodeproj
> 
> to make sure mac dump_syms builds. Maybe I need to run against other
.xcodeproj
> files to make sure everything builds?

That would be good, thanks. As of right now there are 10 files which don't
compile on Mac in the project: 
The following build commands failed: (filtered to CompileC)
	CompileC
build/Breakpad.build/Release/handler_test.build/Objects-normal/i386/BreakpadFramework_Test.o
tests/BreakpadFramework_Test.mm normal i386 objective-c++
com.apple.compilers.llvm.clang.1_0.compiler
	CompileC
build/Breakpad.build/Release/UnitTests.build/Objects-normal/i386/GTMSenTestCase.o
../../common/mac/testing/GTMSenTestCase.m normal i386 objective-c
com.apple.compilers.llvm.clang.1_0.compiler
	CompileC
build/dump_syms.build/Release/dump_syms.build/Objects-normal/i386/dump_syms.o
../../../common/mac/dump_syms.mm normal i386 objective-c++
com.apple.compilers.llvm.clang.1_0.compiler
	CompileC
build/crash_report.build/Release/crash_report.build/Objects-normal/i386/crash_report.o
crash_report.mm normal i386 objective-c++
com.apple.compilers.llvm.clang.1_0.compiler
	CompileC
build/crash_report.build/Release/crash_report.build/Objects-normal/i386/on_demand_symbol_supplier.o
on_demand_symbol_supplier.mm normal i386 objective-c++
com.apple.compilers.llvm.clang.1_0.compiler
	CompileC
build/crash_report.build/Release/crash_report.build/Objects-normal/i386/dump_syms.o
../../../common/mac/dump_syms.mm normal i386 objective-c++
com.apple.compilers.llvm.clang.1_0.compiler
	CompileC
build/crash_report.build/Release/crash_report.build/Objects-normal/i386/functioninfo.o
../../../common/dwarf/functioninfo.cc normal i386 c++
com.apple.compilers.llvm.clang.1_0.compiler
	CompileC
build/crash_report.build/Release/crash_report.build/Objects-normal/i386/x86_disasm.o
../../../third_party/libdisasm/x86_disasm.c normal i386 c
com.apple.compilers.llvm.clang.1_0.compiler
	CompileC
build/dump_syms.build/Release/gtestmockall.build/Objects-normal/i386/gmock-all.o
../../../testing/src/gmock-all.cc normal i386 c++
com.apple.compilers.llvm.clang.1_0.compiler
	CompileC
build/dump_syms.build/Release/gtestmockall.build/Objects-normal/i386/gtest-all.o
../../../testing/gtest/src/gtest-all.cc normal i386 c++
com.apple.compilers.llvm.clang.1_0.compiler

That with xcodebuild -sdk macosx10.7 -project src/client/mac/Breakpad.xcodeproj
-configuration Release -target All ARCHS=i386 ONLY_ACTIVE_ARCH=NO
MACOSX_DEPLOYMENT_TARGET=10.6 GCC_VERSION=com.apple.compilers.llvm.clang.1_0