Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 591002: Make x86-64 stack walking work for Native Client minidumps (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by mseaborn
Modified:
11 years, 6 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk
Visibility:
Public.

Description

Make x86-64 stack walking work for Native Client minidumps

For NaCl, a stack walker should ignore the top 32 bits of %rip, %rsp
and %rbp, otherwise it will try to read from %r15-extended stack
addresses and look up symbol info for %r15-extended code addresses,
which will fail.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3424
TEST=tested manually with a NaCl minidump

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1173

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/google_breakpad/processor/system_info.h View 1 chunk +5 lines, -4 lines 0 comments Download
M src/processor/stackwalker_amd64.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4
mseaborn
I had a brief look at stackwalker_amd64_unittest.cc but wasn't sure how to add a test ...
11 years, 6 months ago #1
bradnelson
LGTM, need mark for owners
11 years, 6 months ago #2
Mark Mentovai
LGTM To answer your question, it’s always possible that a stack will run through some ...
11 years, 6 months ago #3
mseaborn
11 years, 6 months ago #4
Message was sent while issue was closed.
Committed patchset #1 manually as r1173 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted