Issue 589002: dump_syms: Fix load address calculation for prelinked DSOs/PIEs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 589002: dump_syms: Fix load address calculation for prelinked DSOs/PIEs

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by mseaborn

Modified:
11 years, 7 months ago

Reviewers:
Roland McGrath, Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://git.chromium.org/external/google-breakpad.git@master

Visibility:
Public.

More Reviews

Description

dump_syms: Fix load address calculation for prelinked DSOs/PIEs

This is based on Roland McGrath's comments in
https://breakpad.appspot.com/588002/.  This is a speculative fix since
I don't have system with ELF prelinking enabled to test this on.

I wouldn't expect passing prelinked objects to dump_syms to be a
common use case, but it could be useful for dumping symbols of an
installed system library.

BUG= none
TEST= none

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/linux/dump_symbols.cc	View		2 chunks	+15 lines, -9 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

mseaborn

11 years, 7 months ago #1

Since Roland mentioned this, I might as well fix it.  @Mark: please wait for
Roland to check this before committing it.

Expand All Messages | Collapse All Messages