Check in new Windows binaries.

Check in new Windows binaries.

These binaries include recent changes to pdb_source_line_writer for handling
PDBs with OMAP data. They were built using the GYP build files, MSVS 2010 and
DIA SDK 8.0.

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1177

[chrisha]

PTAL.

[Siggi]

lgtm, for what it's worth. You've verified that these binaries work against
msdia80.dll?

[chrisha]

This is build against the newest SDK, so uses msdia100.dll. Are we limited to
using msdia80.dll for some reason? If so, I'll rebuild against that SDK. Mark?

[Mark Mentovai]

Not sure what the bots have on them, but if it’s possible to do this with
msdia80, that’s safest.

[chrisha]

I'm looking into it. Seeing if anybody has an old VS2005 install lying around,
or at least the DIA SDK. Otherwise, I can't built against anything older than
msdia90.dll. I've also got the infra guys looking into the situation on the
buildbots. It might be time to force an upgrade, as msdia80.dll is pretty
ancient.

[Siggi]

Hey, just be thankful it's not COBOL code :). Upgrading sounds like the
sane thing to do, it's years since VS2005 was a supported toolchain for
Chrome.


On Fri, May 3, 2013 at 3:51 PM, <chrisha@chromium.org> wrote:

> I'm looking into it. Seeing if anybody has an old VS2005 install lying
> around, or at least the DIA SDK. Otherwise, I can't built against
> anything older than msdia90.dll. I've also got the infra guys looking
> into the situation on the buildbots. It might be time to force an
> upgrade, as msdia80.dll is pretty ancient.
>
> https://breakpad.appspot.com/**584002/<https://breakpad.appspot.com/584002/>
>

[Mark Mentovai]

The mailing list I referred you to before should at least be able to tell
you what the oldest MSVS we have on any bot that needs to run this is.


On Fri, May 3, 2013 at 3:51 PM, <chrisha@chromium.org> wrote:

> I'm looking into it. Seeing if anybody has an old VS2005 install lying
> around, or at least the DIA SDK. Otherwise, I can't built against
> anything older than msdia90.dll. I've also got the infra guys looking
> into the situation on the buildbots. It might be time to force an
> upgrade, as msdia80.dll is pretty ancient.
>
> https://breakpad.appspot.com/**584002/<https://breakpad.appspot.com/584002/>
>

[chrisha]

Okay, I finally tracked down the 8.0 DIA SDK, and rebuilt these binaries against
it. Confirmed that they run happily. This should sidestep the issue for now, but
we should eventually update our infra.

[Siggi]

lgtm

[Mark Mentovai]

LGTM

[chrisha]

Thanks, committing.