Issue 580002: Remove the API to pass known memory mappings to MinidumpWriter and ExceptionHandler

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 580002: Remove the API to pass known memory mappings to MinidumpWriter and ExceptionHandler

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by glandium

Modified:
11 years, 6 months ago

Reviewers:
Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

Note this does break Mozilla's usecase, but further patches will implement the
required bits to avoid the need to this API altogether. It's just simpler to
remove this before doing that work.

Patch Set 2 : Refreshed against issue 573002 #

Patch Set 3 : Refreshed not to be on top of issue 573002 #

Patch Set 4 : Refreshed to current trunk #

Patch Set 5 : A bit more cleanup #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/client/linux/handler/exception_handler.cc	View	1 2 3	4 chunks	+0 lines, -22 lines	0 comments	Download
M	src/client/linux/handler/exception_handler.h	View		3 chunks	+0 lines, -14 lines	0 comments	Download
M	src/client/linux/handler/exception_handler_unittest.cc	View		2 chunks	+0 lines, -71 lines	0 comments	Download
M	src/client/linux/minidump_writer/minidump_writer.cc	View	1 2 3 4	12 chunks	+16 lines, -66 lines	0 comments	Download
M	src/client/linux/minidump_writer/minidump_writer.h	View		2 chunks	+0 lines, -13 lines	0 comments	Download
M	src/client/linux/minidump_writer/minidump_writer_unittest.cc	View	1 2 3	6 chunks	+18 lines, -220 lines	2 comments	Download
M	src/tools/linux/core2md/core2md.cc	View		2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Ted Mielczarek

LGTM with one change. https://breakpad.appspot.com/580002/diff/12001/src/client/linux/minidump_writer/minidump_writer_unittest.cc File src/client/linux/minidump_writer/minidump_writer_unittest.cc (right): https://breakpad.appspot.com/580002/diff/12001/src/client/linux/minidump_writer/minidump_writer_unittest.cc#newcode341 src/client/linux/minidump_writer/minidump_writer_unittest.cc:341: This hunk seems unrelated?

11 years, 6 months ago #6

glandium

11 years, 6 months ago #7

https://breakpad.appspot.com/580002/diff/12001/src/client/linux/minidump_writ...
File src/client/linux/minidump_writer/minidump_writer_unittest.cc (right):

https://breakpad.appspot.com/580002/diff/12001/src/client/linux/minidump_writ...
src/client/linux/minidump_writer/minidump_writer_unittest.cc:341: 
On 2013/05/17 19:54:46, Ted Mielczarek wrote:
> This hunk seems unrelated?

It's actually not. These streams test had been added to TEST(MinidumpWriterTest,
MappingInfo), I guess to avoid the boilerplate of adding a new test. This moves
these tests to some place else.

Expand All Messages | Collapse All Messages