Issue 571002: Add MD_OS_PS3 to breakpad and exception types.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by jijia

Modified:
11 years, 7 months ago

Reviewers:
Lei Zhang (chromium), thestig1, Ivan Penkov

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add MD_OS_PS3 to breakpad and exception types.

Patch Set 5 : #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
A	src/google_breakpad/common/minidump_exception_ps3.h	View	1 2 3 4	1 chunk	+67 lines, -0 lines	0 comments	Download
M	src/google_breakpad/common/minidump_format.h	View	1 2	2 chunks	+5 lines, -3 lines	0 comments	Download
M	src/processor/exploitability.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/processor/minidump.cc	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	src/processor/minidump_processor.cc	View		2 chunks	+82 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

jijia

Hi Lei, This CL added MD_OS_PS3 and it's exception types. Please help review it and ...

11 years, 7 months ago #1

Ivan Penkov

LGTM https://breakpad.appspot.com/571002/diff/2001/src/google_breakpad/common/minidump_format.h File src/google_breakpad/common/minidump_format.h (right): https://breakpad.appspot.com/571002/diff/2001/src/google_breakpad/common/minidump_format.h#newcode536 src/google_breakpad/common/minidump_format.h:536: #include "minidump_exception_ps3.h" Since you are modifying this include ...

11 years, 7 months ago #2

jijia

https://breakpad.appspot.com/571002/diff/2001/src/google_breakpad/common/minidump_format.h File src/google_breakpad/common/minidump_format.h (right): https://breakpad.appspot.com/571002/diff/2001/src/google_breakpad/common/minidump_format.h#newcode536 src/google_breakpad/common/minidump_format.h:536: #include "minidump_exception_ps3.h" On 2013/04/24 18:08:56, Ivan Penkov wrote: > ...

11 years, 7 months ago #3

Lei Zhang (chromium)

https://breakpad.appspot.com/571002/diff/6001/src/google_breakpad/common/minidump_exception_ps3.h File src/google_breakpad/common/minidump_exception_ps3.h (right): https://breakpad.appspot.com/571002/diff/6001/src/google_breakpad/common/minidump_exception_ps3.h#newcode4 src/google_breakpad/common/minidump_exception_ps3.h:4: * Licensed under the Apache License, Version 2.0 (the ...

11 years, 7 months ago #4

jijia

11 years, 7 months ago #5

Hi Lei,

Could you help me commit this CL? Thanks a lot!

Jia Ji

Expand All Messages | Collapse All Messages