Get SimpleStringDictionary compiling on Linux.

Get SimpleStringDictionary compiling on Linux.

BUG=http://code.google.com/p/chromium/issues/detail?id=77656

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1155

[Mark Mentovai]

https://breakpad.appspot.com/564002/diff/1/src/common/simple_string_dictionary.h
File src/common/simple_string_dictionary.h (left):

https://breakpad.appspot.com/564002/diff/1/src/common/simple_string_dictionar...
src/common/simple_string_dictionary.h:84: strlcpy(value_, value,
sizeof(value_));
Tip: a portable way to do strlcpy where strncpy isn’t available is to do
snprintf(dest, size, "%s", source). I’m just pointing it out because it’s a
one-liner drop-in replacement for strlcpy. But I don’t like it as much as
strncpy + terminate.

https://breakpad.appspot.com/564002/diff/1/src/common/simple_string_dictionary.h
File src/common/simple_string_dictionary.h (right):

https://breakpad.appspot.com/564002/diff/1/src/common/simple_string_dictionar...
src/common/simple_string_dictionary.h:34: #include <vector>
Blank line between these #includes if <vector> is necessary, but I think you can
just remove it.

https://breakpad.appspot.com/564002/diff/1/src/common/simple_string_dictionar...
src/common/simple_string_dictionary.h:85: key_[MAX_STRING_STORAGE_SIZE - 1] =
'\0';
You used sizeof(key_) above but here reverted to the constant. You should be
consistent.

I prefer sizeof.

Same on lines 86 and 94.

[rsesek]

https://breakpad.appspot.com/564002/diff/1/src/common/simple_string_dictionary.h
File src/common/simple_string_dictionary.h (right):

https://breakpad.appspot.com/564002/diff/1/src/common/simple_string_dictionar...
src/common/simple_string_dictionary.h:34: #include <vector>
On 2013/04/19 19:25:13, Mark Mentovai wrote:
> Blank line between these #includes if <vector> is necessary, but I think you
can
> just remove it.

Done.

https://breakpad.appspot.com/564002/diff/1/src/common/simple_string_dictionar...
src/common/simple_string_dictionary.h:85: key_[MAX_STRING_STORAGE_SIZE - 1] =
'\0';
On 2013/04/19 19:25:13, Mark Mentovai wrote:
> You used sizeof(key_) above but here reverted to the constant. You should be
> consistent.
> 
> I prefer sizeof.
> 
> Same on lines 86 and 94.

Done.

[Mark Mentovai]

LGTM

[rsesek]

Committed patchset #2 manually as r1155 (presubmit successful).