Issue 561003: Move SimpleStringDictionary from common/mac/ to just common/.

Issue 561003: Move SimpleStringDictionary from common/mac/ to just common/. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by rsesek

Modified:
11 years, 4 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Move SimpleStringDictionary from common/mac/ to just common/.

This also cleans up some things like the file name, trailing whitespace,
and making the test use gtest instead of sentest, since there's nothing
Mac specific about this.

BUG=https://code.google.com/p/chromium/issues/detail?id=77656

Committed: https://code.google.com/p/google-breakpad/source/detail?r=1154

Patch Set 3 : #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/client/ios/Breakpad.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/client/ios/Breakpad.xcodeproj/project.pbxproj	View		10 chunks	+8 lines, -8 lines	0 comments	Download
M	src/client/mac/Breakpad.xcodeproj/project.pbxproj	View	1 2	16 chunks	+16 lines, -16 lines	0 comments	Download
M	src/client/mac/Framework/Breakpad.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/client/mac/crash_generation/ConfigFile.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/client/mac/crash_generation/ConfigFile.mm	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/client/mac/crash_generation/Inspector.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/client/mac/crash_generation/Inspector.mm	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	src/client/mac/tests/SimpleStringDictionaryTest.h	View		1 chunk	+0 lines, -40 lines	0 comments	Download
D	src/client/mac/tests/SimpleStringDictionaryTest.mm	View		1 chunk	+0 lines, -243 lines	0 comments	Download
D	src/common/mac/SimpleStringDictionary.h	View		1 chunk	+0 lines, -195 lines	0 comments	Download
D	src/common/mac/SimpleStringDictionary.mm	View		1 chunk	+0 lines, -133 lines	0 comments	Download
A +	src/common/simple_string_dictionary.cc	View		4 chunks	+8 lines, -12 lines	0 comments	Download
A +	src/common/simple_string_dictionary.h	View		8 chunks	+20 lines, -23 lines	0 comments	Download
A +	src/common/simple_string_dictionary_unittest.cc	View		6 chunks	+37 lines, -59 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Mark Mentovai

LGTM https://breakpad.appspot.com/561003/diff/1019/src/client/mac/Breakpad.xcodeproj/project.pbxproj File src/client/mac/Breakpad.xcodeproj/project.pbxproj (right): https://breakpad.appspot.com/561003/diff/1019/src/client/mac/Breakpad.xcodeproj/project.pbxproj#newcode2556 src/client/mac/Breakpad.xcodeproj/project.pbxproj:2556: "\"$(SYSTEM_APPS_DIR)/Xcode.app/Contents/Developer/Library/Frameworks\"", Not $(DEVELOPER_FRAMEWORKS_DIR) like the thing that’s being ...

11 years, 4 months ago #2

rsesek

https://breakpad.appspot.com/561003/diff/1019/src/client/mac/Breakpad.xcodeproj/project.pbxproj File src/client/mac/Breakpad.xcodeproj/project.pbxproj (right): https://breakpad.appspot.com/561003/diff/1019/src/client/mac/Breakpad.xcodeproj/project.pbxproj#newcode2556 src/client/mac/Breakpad.xcodeproj/project.pbxproj:2556: "\"$(SYSTEM_APPS_DIR)/Xcode.app/Contents/Developer/Library/Frameworks\"", On 2013/04/18 20:10:52, Mark Mentovai wrote: > Not ...

11 years, 4 months ago #3

Message was sent while issue was closed.

Committed patchset #3 manually as r1154 (presubmit successful).

Expand All Messages | Collapse All Messages