Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(40)

Issue 558002: Add PPC64 support to breakpad processor. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by Lei Zhang (chromium)
Modified:
11 years, 6 months ago
Reviewers:
jijia
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add PPC64 support to breakpad processor.

A=Jia Ji <jijia@google.com>
Original review: https://breakpad.appspot.com/557002/
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1147

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 5 chunks +6 lines, -0 lines 0 comments Download
M Makefile.in View 14 chunks +18 lines, -0 lines 0 comments Download
M src/google_breakpad/common/minidump_cpu_ppc64.h View 1 chunk +8 lines, -8 lines 0 comments Download
M src/google_breakpad/common/minidump_format.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/google_breakpad/processor/minidump.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/google_breakpad/processor/stack_frame_cpu.h View 1 chunk +26 lines, -0 lines 0 comments Download
M src/processor/minidump.cc View 8 chunks +138 lines, -0 lines 0 comments Download
M src/processor/minidump_processor.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/processor/stackwalker.cc View 2 chunks +7 lines, -0 lines 0 comments Download
A src/processor/stackwalker_ppc64.cc View 1 chunk +136 lines, -0 lines 0 comments Download
A src/processor/stackwalker_ppc64.h View 1 chunk +76 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Lei Zhang (chromium)
PTAL
11 years, 6 months ago #1
jijia
On 2013/04/12 23:14:32, thestig wrote: > PTAL LGTM
11 years, 6 months ago #2
Lei Zhang (chromium)
11 years, 6 months ago #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1147 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted