Issue 555002: fixng build by MSVC 2005/2008 compiler with default Windows SDK

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 555002: fixng build by MSVC 2005/2008 compiler with default Windows SDK

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by pelekhay

Modified:
11 years, 8 months ago

Reviewers:
Siggi

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

fixng build by MSVC 2005/2008 compiler with default Windows SDK

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/windows/handler/exception_handler.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Lei Zhang (chromium)

Is the problem the lack of a #include <Ntdef.h> or do we really need this ...

11 years, 8 months ago #1

pelekhay

11 years, 8 months ago #2

On 2013/04/10 23:28:07, thestig wrote:
> Is the problem the lack of a #include <Ntdef.h> or do we really need this
extra
> #define?

As far as I can tell STATUS_INVALID_PARAMETER is not defined for Windows PSDK
6.0a and below.
So inclusion of NtDef.h will not help

Expand All Messages | Collapse All Messages