Fix build on Android - add a missing NT_GNU_BUILD_ID define.

Fix build on Android - put the missing NT_GNU_BUILD_ID #define in
elf_gnu_compat.h and use it where needed.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1146

[Lei Zhang (chromium)]

Just like src/common/linux/file_id.cc. I'll take a lg from whoever gets to it
first. :)

[Mark Mentovai]

Since this happens in more than one place, maybe put it in a common compat
header?

And add a comment explaining what it is—the sort of thing you’d expect to see in
a header—since there might not be a header that defines it.

LGTM though.

[Lei Zhang (chromium)]

On 2013/04/10 00:42:02, Mark Mentovai wrote:
> Since this happens in more than one place, maybe put it in a common compat
> header?
> 
> And add a comment explaining what it is—the sort of thing you’d expect to see
in
> a header—since there might not be a header that defines it.

Done in patch set 3.

[Mark Mentovai]

https://breakpad.appspot.com/554004/diff/3005/src/common/linux/elf_gnu_compat.h
File src/common/linux/elf_gnu_compat.h (right):

https://breakpad.appspot.com/554004/diff/3005/src/common/linux/elf_gnu_compat...
src/common/linux/elf_gnu_compat.h:40: #ifndef NT_GNU_BUILD_ID
IncludeWhatYouUse: who normally #defines this? <elf.h>? Then #include that here.

[Lei Zhang (chromium)]

https://breakpad.appspot.com/554004/diff/3005/src/common/linux/elf_gnu_compat.h
File src/common/linux/elf_gnu_compat.h (right):

https://breakpad.appspot.com/554004/diff/3005/src/common/linux/elf_gnu_compat...
src/common/linux/elf_gnu_compat.h:40: #ifndef NT_GNU_BUILD_ID
On 2013/04/10 01:39:44, Mark Mentovai wrote:
> IncludeWhatYouUse: who normally #defines this? <elf.h>? Then #include that
here.

Should I just replace <elf.h> includes with this then?

[Mark Mentovai]

Nah, this is good now.

IWYU as I interpret it says to #include this new compat file only for things
that it provides, but to #include <elf.h> directly in files that use any other
thing that <elf.h> offers.

[Mark Mentovai]

That is: LGTM

[Lei Zhang (chromium)]

Committed patchset #4 manually as r1146 (presubmit successful).