Issue 549002: Allow efficient and save "opt-out" from in-proc dump generation. (Closed)
DescriptionAllow efficient and safe "opt-out" from in-proc dump generation. When
out-of-proc dump generation fails to initialize (fails to register with the
crash generation server), all ExceptionHandler constructors that we currently
have fail back to in-proc dump generation.
Apparently, there are Breakpad users who doesn't want to deal with in-proc dump
generation which leads to code like this:
handler = new google_breakpad::ExceptionHandler(.....);
if (!handler->IsOutOfProcess()) {
delete g_handler;
return false;
}
This is inefficient and unsafe because the constructors and destructors of
ExceptionHandler do many things in in-proc dump generation mode. For example,
they create a background thread and calls LoadLibrary in the constructor, and
waits for a thread termination in the destructor.
If needed, this "opt-out" behavior can be extended to Mac and Linux as well.
For the time being it has only been requested for Windows.
Thanks,
-Ivan
Patch Set 1 #Patch Set 2 : Removing an extra comment line that accidentally went in #
Total comments: 14
Patch Set 3 : Fixing indentation and typos in comments #
MessagesTotal messages: 5
|
||||||||||||||||||||||||||||||||||||||||||||||
