Issue 547002: Structured logging prerequisites. Wrapping std::ostream with a new type.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 547002: Structured logging prerequisites. Wrapping std::ostream with a new type. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by Ivan Penkov

Modified:
12 years, 4 months ago

Reviewers:
Ted Mielczarek, Mark Mentovai, Josh M.

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/src/

Visibility:
Public.

More Reviews

Description

These are prerequisites needed for a wider effort inside Google to enable
structured logging.  This is basically wrapping std::ostream within a new type. 
No functional differences from this change are expected.

Thanks,
-Ivan

Patch Set 1 #

Patch Set 2 : Refining the comment #

Patch Set 3 : Revised the #ifdef to specifically check for Google glue logging #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	processor/logging.h	View	1 2	2 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Mark Mentovai

12 years, 4 months ago #5

Committed r1140.


On Wed, Apr 3, 2013 at 2:29 PM, <mark@chromium.org> wrote:

> LGTM
>
> http://breakpad.appspot.com/**547002/<http://breakpad.appspot.com/547002/>
>

Expand All Messages | Collapse All Messages