Issue 544003: Try to find a build-id through PT_NOTE program headers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 544003: Try to find a build-id through PT_NOTE program headers (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by glandium

Modified:
11 years, 7 months ago

Reviewers:
Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

Try to find a build-id through PT_NOTE program headers

Patch Set 2 : With comment #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/common/linux/elfutils.cc	View		2 chunks	+65 lines, -0 lines	0 comments	Download
M	src/common/linux/elfutils.h	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/common/linux/file_id.cc	View	1	2 chunks	+27 lines, -10 lines	0 comments	Download
M	src/common/linux/file_id_unittest.cc	View		1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Ted Mielczarek

LGTM with one nit https://breakpad.appspot.com/544003/diff/1/src/common/linux/file_id.cc File src/common/linux/file_id.cc (right): https://breakpad.appspot.com/544003/diff/1/src/common/linux/file_id.cc#newcode58 src/common/linux/file_id.cc:58: #define NOTE_PADDING(a) ((a + 3) ...

11 years, 8 months ago #2

Expand All Messages | Collapse All Messages