Issue 543002: Defer adding sections until ELF::Finish in synth_elf

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 543002: Defer adding sections until ELF::Finish in synth_elf (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by glandium

Modified:
11 years, 7 months ago

Reviewers:
Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

Defer adding sections until ELF::Finish in synth_elf

Patch Set 1 #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/linux/synth_elf.cc	View		2 chunks	+14 lines, -6 lines	0 comments	Download
	M	src/common/linux/synth_elf.h	View		3 chunks	+19 lines, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Ted Mielczarek

11 years, 8 months ago #2

LGTM

https://breakpad.appspot.com/543002/diff/1/src/common/linux/synth_elf.h
File src/common/linux/synth_elf.h (right):

https://breakpad.appspot.com/543002/diff/1/src/common/linux/synth_elf.h#newco...
src/common/linux/synth_elf.h:149: void AddSection(ElfSection &section);
I think this would make slightly more sense as "AppendSection" to distinguish it
from the existing AddSection method. I'll just fix that on checkin.

Expand All Messages | Collapse All Messages