Issue 539003: Fix Windows unittest build on VC2012

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 539003: Fix Windows unittest build on VC2012 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by Ted Mielczarek

Modified:
11 years, 8 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

Visual C++ 2012 chokes on Google Test's variadic macros unless you specify
-D__VARIADIC_MAX=10. (Per
http://stackoverflow.com/questions/12558327/google-test-in-visual-studio-2012 )
This is silly, but everything builds fine on Visual C++ 2012 with this patch
applied

Patch Set 1 #

Patch Set 2 : Actual patch #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/windows/unittests/testing.gyp	View		2 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

This is certainly weird and worth a comment in the .gyp file. LGTM otherwise.

Expand All Messages | Collapse All Messages