Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(377)

Issue 537002: Remove "library" variable. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by tfarina
Modified:
11 years, 7 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Remove "library" variable.

BUG=http://code.google.com/p/chromium/issues/detail?id=111541
R=thestig@chromium.org

Signed-off-by: Thiago Farina <tfarina@chromium.org>

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/windows/build/common.gypi View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 4
tfarina
Hi Lei, could you actually try this on Windows? Thanks,
11 years, 8 months ago #1
Lei Zhang (chromium)
On 2013/03/04 20:57:12, tfarina wrote: > Hi Lei, could you actually try this on Windows? ...
11 years, 8 months ago #2
tfarina
On 2013/03/05 00:52:26, thestig wrote: > On 2013/03/04 20:57:12, tfarina wrote: > > Hi Lei, ...
11 years, 8 months ago #3
Ted Mielczarek
11 years, 8 months ago #4
On 2013/03/05 17:17:54, tfarina wrote:
> Ted, would you be able to patch this and try on a Windows box?
> 
> If it looks good to you, could you land this to me?

Builds fine on Windows for me. I just landed it for you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted