Issue 535003: Fix some more processor code to build on Win32

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 535003: Fix some more processor code to build on Win32 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by Ted Mielczarek

Modified:
11 years, 8 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

We're building more of the processor on Windows for Mozilla, so this fixes a few
little portability issues.

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/google_breakpad/common/breakpad_types.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/processor/basic_source_line_resolver.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/processor/cfi_frame_info.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/processor/source_line_resolver_base_types.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/processor/tokenize.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/processor/windows_frame_info.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 2

LGTM