Issue 521002: Minor Android fixup in symbol dumping code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 521002: Minor Android fixup in symbol dumping code (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by Ted Mielczarek

Modified:
11 years, 8 months ago

Reviewers:
digit

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

We're going to be building and using the symbol dumping code on Android. This
patch works around a few things that were broken. Original patch by Julian
Seward.

Patch Set 1 #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/dwarf_cu_to_module.cc	View		3 chunks	+9 lines, -4 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

digit

11 years, 8 months ago #3

Sorry, I didn't catch your first email. Thanks. LGTM

https://breakpad.appspot.com/521002/diff/1/src/common/dwarf_cu_to_module.cc
File src/common/dwarf_cu_to_module.cc (right):

https://breakpad.appspot.com/521002/diff/1/src/common/dwarf_cu_to_module.cc#n...
src/common/dwarf_cu_to_module.cc:42: #if !defined(__ANDROID__)
FYI,all recent Android NDK release provide <cxxabi.h> when building against
STLport or GNU libstdc++, so this #if !defined() shouldn't be needed anymore.

On the other hand, abi::__cxa_demangle() is not available yet, and this seems to
be the only usage of said header here, so it makes sense to keep that for now.

Expand All Messages | Collapse All Messages