Issue 512002: Make DumpSymbols methods take a vector of debug_dirs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 512002: Make DumpSymbols methods take a vector of debug_dirs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by Ted Mielczarek

Modified:
11 years, 10 months ago

Reviewers:
jimb, Mark Mentovai, Lei Zhang (chromium)

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Fairly straightforward, we have need of this.

Total comments: 2

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/common/linux/dump_symbols.cc	View	1	7 chunks	+35 lines, -21 lines	0 comments	Download
M	src/common/linux/dump_symbols.h	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/common/linux/dump_symbols_unittest.cc	View		4 chunks	+8 lines, -8 lines	0 comments	Download
M	src/tools/linux/dump_syms/dump_syms.cc	View	1	1 chunk	+13 lines, -12 lines	0 comments	Download

Total messages: 8

Lei Zhang (chromium)

There will to be a future change that puts more than 1 path in the ...

11 years, 10 months ago #3

Ted Mielczarek

On 2013/01/18 20:06:00, thestig wrote: > There will to be a future change that puts ...

11 years, 10 months ago #4

Ted Mielczarek

On 2013/01/18 20:14:39, thestig wrote: > Please do. Fixed, and fixed the other issues you ...

11 years, 10 months ago #7

lgtm