Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(47)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
509003
: Fix some warnings in stack_frame_symbolizer (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by
Ted Mielczarek
Modified:
11 years, 10 months ago
Reviewers:
siyangxie
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.
More Reviews
Description
These are probably mostly from Mozilla compiling with -pedantic, but they seem reasonable.
Patch Set 1
#
Created:
11 years, 10 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
Patch
M
src/google_breakpad/processor/stack_frame_symbolizer.h
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/processor/stack_frame_symbolizer.cc
View
1 chunk
+1 line, -0 lines
0 comments
Download
Messages
Total messages: 2
Expand All Messages
|
Collapse All Messages
Ted Mielczarek
11 years, 10 months ago
#1
Sign in
to reply to this message.
SiyangXie
LGTM
11 years, 10 months ago
#2
LGTM
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 509003: Fix some warnings in stack_frame_symbolizer (Closed)
Created 11 years, 10 months ago by Ted Mielczarek
Modified 11 years, 10 months ago
Reviewers: siyangxie_gmail.com
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
1004:630ec63f810e-tainted