Updating BreakpadController to allow start and stop being nop.

Updating BreakpadController to allow start and stop being nop.

 When BreakpadController is already started or stopped, trying to restart it or
restopping it will now be no-op instead of asserting.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1092

[Mark Mentovai]

LGTM

https://breakpad.appspot.com/505002/diff/1/src/client/ios/BreakpadController.mm
File src/client/ios/BreakpadController.mm (right):

https://breakpad.appspot.com/505002/diff/1/src/client/ios/BreakpadController....
src/client/ios/BreakpadController.mm:132: void(^startBlock)() = ^{
Let’s move the declaration of startBlock down to where it’s actually needed,
right before testing onCurrentThread.

[qsr]

https://breakpad.appspot.com/505002/diff/1/src/client/ios/BreakpadController.mm
File src/client/ios/BreakpadController.mm (right):

https://breakpad.appspot.com/505002/diff/1/src/client/ios/BreakpadController....
src/client/ios/BreakpadController.mm:132: void(^startBlock)() = ^{
On 2012/12/17 14:17:22, Mark Mentovai wrote:
> Let’s move the declaration of startBlock down to where it’s actually needed,
> right before testing onCurrentThread.

Done.

[glider]

Am I understanding correctly that start() and stop() can be called from two
different threads? If so, I smell bad synchronization here.

[qsr1]

 Start and stop must be called from the same thread.


On Tue, Jan 15, 2013 at 9:52 AM, <glider@chromium.org> wrote:

> Am I understanding correctly that start() and stop() can be called from
> two different threads? If so, I smell bad synchronization here.
>
> https://breakpad.appspot.com/**505002/<https://breakpad.appspot.com/505002/>
>



-- 
        Benjamin

[glider]

Ok, sorry for the false alarm.

[qsr]

 Start and stop must be called from the same thread. The controller is not
thread safe.


On Tue, Jan 15, 2013 at 10:44 AM, Benjamin Lerman <qsr@google.com> wrote:

>  Start and stop must be called from the same thread.
>
>
> On Tue, Jan 15, 2013 at 9:52 AM, <glider@chromium.org> wrote:
>
>> Am I understanding correctly that start() and stop() can be called from
>> two different threads? If so, I smell bad synchronization here.
>>
>> https://breakpad.appspot.com/**505002/<https://breakpad.appspot.com/505002/>
>>
>
>
>
> --
>         Benjamin
>