Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8694)

Issue 504002: Fix minidump size limit used for MinidumpSizeLimit unittest (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by Michael Krebs
Modified:
11 years, 3 months ago
Reviewers:
Ivan Penkov
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix minidump size limit used for MinidumpSizeLimit unittest

If the stack sizes for threads in the MinidumpSizeLimit test are too big,
then subtracting 64KB from the normal minidump file size is not enough to
trigger the size-limiting logic.  Instead of basing the arbitrary limit off
of the normal file size, make it relative to the 8KB stack size the logic
assumes.

BUG=google-breakpad:510
TEST=Ran unittests
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/minidump_writer/minidump_writer_unittest.cc View 3 chunks +25 lines, -4 lines 0 comments Download

Messages

Total messages: 2
Michael Krebs
11 years, 3 months ago #1
Ivan Penkov
11 years, 3 months ago #2
This looks good.  I verified that the test now passes in google3:

//third_party/breakpad:google/test/minidump_writer_unittest              PASSED
in 1.6s

Thanks,
-Ivan
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted