Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(64)

Issue 503002: Mac/iOS Breakpad client: exceptions off, no libstdc++ (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by Mark Mentovai
Modified:
11 years, 11 months ago
Reviewers:
qsr
CC:
google-breakpad-dev_googlegroups.com, thakis
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Allow the Mac and iOS Breakpad clients to build without exceptions when the C++
standard library is not provided by libstdc++. libc++, for example, does 
not provide its own try and catch replacement macros when exceptions are
disabled.

BUG=509
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1089

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/ios/Breakpad.mm View 1 1 chunk +19 lines, -7 lines 0 comments Download
M src/client/mac/Framework/Breakpad.mm View 2 chunks +15 lines, -2 lines 0 comments Download
M src/client/mac/handler/exception_handler.cc View 1 chunk +14 lines, -1 line 0 comments Download

Messages

Total messages: 2
Mark Mentovai
11 years, 11 months ago #1
qsr
11 years, 11 months ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted