Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 499003: Add assertion on initialization sequence. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 12 months ago by qsr
Modified:
11 years, 12 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

 Add assertion on initialization sequence.

 The order at which to call the controller methods is:
1) Any method that change the configuration_ field
2) start
3) Any other method

 This change adds assertion that it is done correctly.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1085

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/ios/BreakpadController.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/client/ios/BreakpadController.mm View 1 9 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 2
qsr
11 years, 12 months ago #1
Mark Mentovai
11 years, 12 months ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted