Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 495002: Linux: Avoid truncating the vendor id. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by Lei Zhang (chromium)
Modified:
11 years, 4 months ago
Reviewers:
digit
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Linux: Avoid truncating the vendor id.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1079

Patch Set 1 #

Patch Set 2 : Avoid writing into the LineReader buffer #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/minidump_writer/minidump_writer.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 3
Lei Zhang (chromium)
strlcpy != strncpy. Doh.
11 years, 4 months ago #1
Lei Zhang (chromium)
On 2012/11/08 04:00:23, thestig wrote: > strlcpy != strncpy. Doh. Please see patch set 2.
11 years, 4 months ago #2
digit
11 years, 4 months ago #3
Damned. lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted