Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 492002: Fix assertion failure in WriteMappings() for zero modules (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by Michael Krebs
Modified:
11 years, 4 months ago
Reviewers:
Ted Mielczarek
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix assertion failure in WriteMappings() for zero modules

If there were no mappings where ShouldIncludeMapping() returned true,
AllocateObjectAndArray() would die with an assertion failure.

BUG=chrome-os-partner:14914
TEST=Ran unittests
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/minidump_writer/minidump_writer.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Michael Krebs
11 years, 5 months ago #1
Ted Mielczarek
LGTM Not sure if this is easily unit-testable, it would be nice to have a ...
11 years, 4 months ago #2
Michael Krebs
11 years, 4 months ago #3
Yeah, I don't see an easy way without implementing some hooks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted