Building fails with gcc 4.1 due to unsupported -Werror= switch

GCC 4.2 and below do not support the -Werror switch that takes a value. Also,
ensure that compilation tests use a C++ compiler.

[Lei Zhang (chromium)]

My autoconf-fu is pretty weak.

http://breakpad.appspot.com/490002/diff/1/Makefile.in
File Makefile.in (right):

http://breakpad.appspot.com/490002/diff/1/Makefile.in#newcode151
Makefile.in:151: @ANDROID_HOST_TRUE@@LINUX_HOST_TRUE@	-llog -lm
Is this needed?

[Ted Mielczarek]

https://breakpad.appspot.com/490002/diff/1/configure.ac
File configure.ac (right):

https://breakpad.appspot.com/490002/diff/1/configure.ac#newcode152
configure.ac:152: CXXFLAGS="-Werror=overloaded-virtual"
Is this test really correct? You're testing that the compiler accepts
-Werror=overloaded-virtual, but not that it accepts any of the other options we
set in Makefile.am. I think I'd prefer if you set an ERROR_CXXFLAGS here, test
that all of those options work, and then subst that and set CXXFLAGS +=
$(ERROR_CXXFLAGS). That way if we add more -Werror switches in the future they
won't cause breakage for compilers that don't support them.

[davi.arnaut]

https://breakpad.appspot.com/490002/diff/1/Makefile.in
File Makefile.in (right):

https://breakpad.appspot.com/490002/diff/1/Makefile.in#newcode151
Makefile.in:151: @ANDROID_HOST_TRUE@@LINUX_HOST_TRUE@	-llog -lm
On 2012/10/26 18:57:06, thestig wrote:
> Is this needed?
No idea, that's generated. It is unrelated, but looks right.

https://breakpad.appspot.com/490002/diff/1/configure.ac
File configure.ac (right):

https://breakpad.appspot.com/490002/diff/1/configure.ac#newcode152
configure.ac:152: CXXFLAGS="-Werror=overloaded-virtual"
It should be fine if the flag being tested was the most recently supported.
Anyway, we can also check the flags one by one.