Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 486002: Minor cleanup in src/client/linux/minidump_writer/minidump_writer_unittest.cc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by Lei Zhang (chromium)
Modified:
11 years, 4 months ago
Reviewers:
Ted Mielczarek
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Minor cleanup in src/client/linux/minidump_writer/minidump_writer_unittest.cc.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1078

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/minidump_writer/minidump_writer_unittest.cc View 13 chunks +18 lines, -18 lines 2 comments Download

Messages

Total messages: 3
Lei Zhang (chromium)
11 years, 5 months ago #1
Ted Mielczarek
LGTM https://breakpad.appspot.com/486002/diff/1/src/client/linux/minidump_writer/minidump_writer_unittest.cc File src/client/linux/minidump_writer/minidump_writer_unittest.cc (right): https://breakpad.appspot.com/486002/diff/1/src/client/linux/minidump_writer/minidump_writer_unittest.cc#newcode85 src/client/linux/minidump_writer/minidump_writer_unittest.cc:85: string templ = temp_dir.path() + kMDWriterUnitTestFileName; Is it ...
11 years, 5 months ago #2
Lei Zhang (chromium)
11 years, 4 months ago #3
https://breakpad.appspot.com/486002/diff/1/src/client/linux/minidump_writer/m...
File src/client/linux/minidump_writer/minidump_writer_unittest.cc (right):

https://breakpad.appspot.com/486002/diff/1/src/client/linux/minidump_writer/m...
src/client/linux/minidump_writer/minidump_writer_unittest.cc:85: string templ =
temp_dir.path() + kMDWriterUnitTestFileName;
On 2012/10/16 13:33:56, Ted Mielczarek wrote:
> Is it worthwhile to move this into a test fixture instead?

I'm rather "meh" about it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted