Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(126)

Issue 485002: Merge r1065: Don't bail if a thread's stack pointer is invalid (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 11 months ago by Lei Zhang (chromium)
Modified:
5 years, 11 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/branches/chrome_23/
Visibility:
Public.

Description

Merge r1065: Don't bail if a thread's stack pointer is invalid

Currently, if a thread's stack pointer is not within a valid memory page,
the minidump writing will fail with an error.  This change allows an invalid
stack pointer by simply setting the memory size to zero in the minidump.
The processing code already checks for the size being zero, although it
currently just gives an error (see https://breakpad.appspot.com/413002/).

BUG=google-breakpad:499, chromium-os:34880
TEST=make check, manually ran minidump-2-core and core2md
Original Review URL: https://breakpad.appspot.com/478002

* To make this build, there is an additional #include <ucontext.h>.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1071

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/minidump_writer/linux_core_dumper.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/client/linux/minidump_writer/linux_core_dumper_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/client/linux/minidump_writer/linux_dumper.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/client/linux/minidump_writer/linux_ptrace_dumper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/client/linux/minidump_writer/minidump_writer.cc View 4 chunks +45 lines, -27 lines 0 comments Download
M src/client/linux/minidump_writer/minidump_writer_unittest.cc View 2 chunks +81 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Lei Zhang (chromium)
5 years, 11 months ago #1
Mark Mentovai
5 years, 11 months ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted