Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(267)

Issue 482002: Fix the Android unit tests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by digit
Modified:
7 years, 2 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix the Android unit tests.

- One of the unit test binaries refused to link due to
  missing linker flags.

- The WriteDSODebug() function now works on Android, so
  do not special-case it anymore.

- Ensure android/run-checks.sh will complain properly if
  the client unit test suite fails on Android. It used to
  consider that such failures were acceptable. Note that
  it still considers failures when running the tools and
  processor test suite on the device normal (fixing this
  is a lot harder, and these parts of Breakpad typically
  never run on a device, but on the host).
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1066

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 2 chunks +5 lines, -1 line 0 comments Download
M Makefile.in View 2 chunks +5 lines, -3 lines 0 comments Download
M android/run-checks.sh View 1 chunk +21 lines, -16 lines 0 comments Download
M src/client/linux/minidump_writer/minidump_writer.cc View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2
digit
7 years, 2 months ago #1
Mark Mentovai
7 years, 2 months ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted