Issue 479003: Comment out the (unused) variable name in the function definition

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 479003: Comment out the (unused) variable name in the function definition

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by rafael.espindola

Modified:
12 years, 2 months ago

Reviewers:
jimb, jimb

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Comment out the (unused) variable name in the function definition

This is required by the style guide:

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/dwarf/dwarf2diehandler.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/common/dwarf_cu_to_module.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rafael.espindola

On 2012/10/05 20:38:41, jimb wrote: > LGTM I don't have commit access. Can you commit ...

12 years, 2 months ago #3

jimb_red-bean.com

12 years, 2 months ago #4

Tweaked a bit to comply with the style guide, and committed as r1064.

Oddly, I don't seem to be able to post to the Rietveld issue; I get an
"over quota" error message. Perhaps Google is running out of disk
space.

On Fri, Oct 5, 2012 at 1:40 PM,  <rafael.espindola@gmail.com> wrote:
> On 2012/10/05 20:38:41, jimb wrote:
>>
>> LGTM
>
>
> I don't have commit access. Can you commit it?
>
> http://breakpad.appspot.com/479003/

Expand All Messages | Collapse All Messages