Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(156)

Issue 476002: Update dump_syms to correctly filter on cpu subtype. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by qsr
Modified:
11 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

 Update dump_syms to correctly filter on cpu subtype.

 Right now, if an archive contain multiple executable for the same CPU but with
different subtype, there is no way to dump any but the first one.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1061

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/mac/handler/minidump_generator.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M src/common/mac/arch_utilities.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/common/mac/dump_syms.mm View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/common/mac/file_id.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M src/common/mac/file_id.h View 1 2 3 chunks +10 lines, -7 lines 0 comments Download
M src/common/mac/macho_id.cc View 1 2 3 chunks +16 lines, -11 lines 0 comments Download
M src/common/mac/macho_id.h View 1 2 3 chunks +22 lines, -11 lines 0 comments Download
M src/common/mac/macho_walker.cc View 1 2 3 4 4 chunks +20 lines, -17 lines 0 comments Download
M src/common/mac/macho_walker.h View 1 2 3 4 3 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 5
qsr
11 years, 5 months ago #1
Mark Mentovai
https://breakpad.appspot.com/476002/diff/2001/src/client/mac/handler/minidump_generator.cc File src/client/mac/handler/minidump_generator.cc (right): https://breakpad.appspot.com/476002/diff/2001/src/client/mac/handler/minidump_generator.cc#newcode1307 src/client/mac/handler/minidump_generator.cc:1307: result = macho.UUIDCommand(cpu_type, 0, identifier); Instead of 0, can ...
11 years, 5 months ago #2
qsr
https://breakpad.appspot.com/476002/diff/2001/src/client/mac/handler/minidump_generator.cc File src/client/mac/handler/minidump_generator.cc (right): https://breakpad.appspot.com/476002/diff/2001/src/client/mac/handler/minidump_generator.cc#newcode1307 src/client/mac/handler/minidump_generator.cc:1307: result = macho.UUIDCommand(cpu_type, 0, identifier); Used CPU_SUBTYPE_MULTIPLE, this is ...
11 years, 5 months ago #3
Mark Mentovai
LGTM otherwise https://breakpad.appspot.com/476002/diff/4003/src/common/mac/macho_walker.cc File src/common/mac/macho_walker.cc (right): https://breakpad.appspot.com/476002/diff/4003/src/common/mac/macho_walker.cc#newcode83 src/common/mac/macho_walker.cc:83: bool MachoWalker::WalkHeader(int cpu_type, int cpu_subtype) { You ...
11 years, 5 months ago #4
qsr
11 years, 5 months ago #5
https://breakpad.appspot.com/476002/diff/4003/src/common/mac/macho_walker.cc
File src/common/mac/macho_walker.cc (right):

https://breakpad.appspot.com/476002/diff/4003/src/common/mac/macho_walker.cc#...
src/common/mac/macho_walker.cc:83: bool MachoWalker::WalkHeader(int cpu_type,
int cpu_subtype) {
 Missed it. Fixed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted