Add custom implementation of NXGetArchInfoXXX to allow adding new arch.

Add custom implementation of NXGetArchInfoXXX to allow adding new arch.

NXGetArchInfoXXX depends on the OS knowledge of architecture. This CL adds a
custom implementation of those methods to be able to handle newer CPU before
they are handled by the OS. It also add handling for armv7s architecture.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1057

[Ted Mielczarek]

https://breakpad.appspot.com/475002/diff/1/src/tools/mac/dump_syms/dump_syms_...
File src/tools/mac/dump_syms/dump_syms_tool.mm (right):

https://breakpad.appspot.com/475002/diff/1/src/tools/mac/dump_syms/dump_syms_...
src/tools/mac/dump_syms/dump_syms_tool.mm:42: #include
"common/mac/arch_utilities.h"
It looks like you forgot to include this new file in your patch, FYI.

[qsr]

Thanks. Done.

[Ted Mielczarek]

https://breakpad.appspot.com/475002/diff/3001/src/common/mac/arch_utilities.h
File src/common/mac/arch_utilities.h (right):

https://breakpad.appspot.com/475002/diff/3001/src/common/mac/arch_utilities.h...
src/common/mac/arch_utilities.h:37: namespace MacArchUtils {
Google style guide says namespace names are all lowercase with underscores
between words.

[Mark Mentovai]

https://breakpad.appspot.com/475002/diff/3001/src/common/mac/arch_utilities.cc
File src/common/mac/arch_utilities.cc (right):

https://breakpad.appspot.com/475002/diff/3001/src/common/mac/arch_utilities.c...
src/common/mac/arch_utilities.cc:37: #endif //  CPU_TYPE_ARM
Nit: you’re supposed to put the extra space on the left side of the //, not the
right.

https://breakpad.appspot.com/475002/diff/3001/src/common/mac/arch_utilities.c...
src/common/mac/arch_utilities.cc:56: static NXArchInfo armv7s_arch_info;
Isn’t this better? Let the compiler worry about initializing the static.

static const NXArchInfo* ArchInfo_armv7s() {
  NXArchInfo* armv7s = new NXArchInfo;
  // …
  armv7s->name = "armv7s";
  // …
  return armv7s;
}

const NXArchInfo* BreakpadGetArchInfoFromCpuType(…) {
  if (cpu_type == CPU_TYPE_ARM && cpu_subtype == kArmv7sCpuSubType) {
    static const NXArchInfo* armv7s_arch_info = ArchInfo_armv7s();
    return armv7s_arch_info;
  }
  return NXGetArchInfoFromCpuType(cpu_type, cpu_subtype);
}

[qsr]

https://breakpad.appspot.com/475002/diff/3001/src/common/mac/arch_utilities.cc
File src/common/mac/arch_utilities.cc (right):

https://breakpad.appspot.com/475002/diff/3001/src/common/mac/arch_utilities.c...
src/common/mac/arch_utilities.cc:37: #endif //  CPU_TYPE_ARM
On 2012/10/03 13:06:51, Mark Mentovai wrote:
> Nit: you’re supposed to put the extra space on the left side of the //, not
the
> right.

Done.

https://breakpad.appspot.com/475002/diff/3001/src/common/mac/arch_utilities.c...
src/common/mac/arch_utilities.cc:56: static NXArchInfo armv7s_arch_info;
On 2012/10/03 13:06:51, Mark Mentovai wrote:
> Isn’t this better? Let the compiler worry about initializing the static.
> 
> static const NXArchInfo* ArchInfo_armv7s() {
>   NXArchInfo* armv7s = new NXArchInfo;
>   // …
>   armv7s->name = "armv7s";
>   // …
>   return armv7s;
> }
> 
> const NXArchInfo* BreakpadGetArchInfoFromCpuType(…) {
>   if (cpu_type == CPU_TYPE_ARM && cpu_subtype == kArmv7sCpuSubType) {
>     static const NXArchInfo* armv7s_arch_info = ArchInfo_armv7s();
>     return armv7s_arch_info;
>   }
>   return NXGetArchInfoFromCpuType(cpu_type, cpu_subtype);
> }

Done.

https://breakpad.appspot.com/475002/diff/3001/src/common/mac/arch_utilities.h
File src/common/mac/arch_utilities.h (right):

https://breakpad.appspot.com/475002/diff/3001/src/common/mac/arch_utilities.h...
src/common/mac/arch_utilities.h:37: namespace MacArchUtils {
 Changed to google_breakpad

[Mark Mentovai]

LGTM