Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(70)

Issue 4734002: minidump_stackwalk can now output in Apple Crash Report format.

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by rohitrao
Modified:
2 years, 8 months ago
Reviewers:
Mark Mentovai, rsesek
Base URL:
https://chromium.googlesource.com/external/google-breakpad/src.git@master
Visibility:
Public.

Description

minidump_stackwalk can now output in Apple Crash Report format.

BUG=None

Patch Set 1 #

Patch Set 2 : Usage #

Patch Set 3 : For Mark. #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M google_breakpad/processor/minidump_processor.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M google_breakpad/processor/process_state.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M processor/minidump_processor.cc View 1 2 3 chunks +29 lines, -1 line 1 comment Download
M processor/minidump_stackwalk.cc View 1 2 5 chunks +32 lines, -10 lines 0 comments Download
M processor/stackwalk_common.cc View 1 2 9 chunks +541 lines, -256 lines 7 comments Download
M processor/stackwalk_common.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
rohitrao
I can try to put this into crsym/ instead, but here's what I needed to ...
2 years, 8 months ago #1
Mark Mentovai
OK, can you take a quick look at https://breakpad.appspot.com/4744002/ for me too?
2 years, 8 months ago #2
rohitrao
On 2015/03/25 22:24:39, Mark Mentovai wrote: > OK, can you take a quick look at ...
2 years, 8 months ago #3
Mark Mentovai
2 years, 8 months ago #4
https://breakpad.appspot.com/4734002/diff/40001/processor/minidump_processor.cc
File processor/minidump_processor.cc (right):

https://breakpad.appspot.com/4734002/diff/40001/processor/minidump_processor....
processor/minidump_processor.cc:150: (has_requesting_thread   ? "" : "no ") <<
"requesting thread, and " <<
This “and” should disappear and “create time” should sprout it.

https://breakpad.appspot.com/4734002/diff/40001/processor/stackwalk_common.cc
File processor/stackwalk_common.cc (right):

https://breakpad.appspot.com/4734002/diff/40001/processor/stackwalk_common.cc...
processor/stackwalk_common.cc:105: const char* name;
These pointers can be conster.

https://breakpad.appspot.com/4734002/diff/40001/processor/stackwalk_common.cc...
processor/stackwalk_common.cc:312: Register32 data[] = {
These structs should be const.

https://breakpad.appspot.com/4734002/diff/40001/processor/stackwalk_common.cc...
processor/stackwalk_common.cc:326: for (int i = 0; i < 10; ++i) {
Not 10, but arraysize.

https://breakpad.appspot.com/4734002/diff/40001/processor/stackwalk_common.cc...
processor/stackwalk_common.cc:1147: printf("Incident Identifier:
04C9BA62-4E89-4442-9B4D-CD0C77D7D8B9\n");
I’m not happy with these or the hard-coded com.google.chromes. I suggest leaving
them out or adding them in some wrapper script that’s not checked in here. You
can leave placeholder strings like @INCIDENT_ID@ and @BUNDLE_ID@ to easily be
replaced by sed.

https://breakpad.appspot.com/4734002/diff/40001/processor/stackwalk_common.cc...
processor/stackwalk_common.cc:1170: char dateBuf[64];
date_buf

https://breakpad.appspot.com/4734002/diff/40001/processor/stackwalk_common.cc...
processor/stackwalk_common.cc:1173: strftime(dateBuf, 64, "%Y-%m-%d %k:%M:%S.000
%z", crash_time);
sizeof(date_buf)

https://breakpad.appspot.com/4734002/diff/40001/processor/stackwalk_common.cc...
processor/stackwalk_common.cc:1182: // TODO(rohitrao): Add parens around the
build number.
?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted