Issue 4734002: minidump_stackwalk can now output in Apple Crash Report format.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 4734002: minidump_stackwalk can now output in Apple Crash Report format.

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 1 month ago by rohitrao

Modified:
9 years, 1 month ago

Reviewers:
Mark Mentovai, rsesek

Base URL:
https://chromium.googlesource.com/external/google-breakpad/src.git@master

Visibility:
Public.

More Reviews

Description

minidump_stackwalk can now output in Apple Crash Report format.

BUG=None

Patch Set 1 #

Patch Set 2 : Usage #

Patch Set 3 : For Mark. #

Total comments: 8

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	google_breakpad/processor/minidump_processor.h	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	google_breakpad/processor/process_state.h	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	processor/minidump_processor.cc	View	1 2	3 chunks	+29 lines, -1 line	1 comment	Download
M	processor/minidump_stackwalk.cc	View	1 2	5 chunks	+32 lines, -10 lines	0 comments	Download
M	processor/stackwalk_common.cc	View	1 2	9 chunks	+541 lines, -256 lines	7 comments	Download
M	processor/stackwalk_common.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Mark Mentovai

OK, can you take a quick look at https://breakpad.appspot.com/4744002/ for me too?

9 years, 1 month ago #2

Mark Mentovai

9 years, 1 month ago #4

https://breakpad.appspot.com/4734002/diff/40001/processor/minidump_processor.cc
File processor/minidump_processor.cc (right):

https://breakpad.appspot.com/4734002/diff/40001/processor/minidump_processor....
processor/minidump_processor.cc:150: (has_requesting_thread   ? "" : "no ") <<
"requesting thread, and " <<
This “and” should disappear and “create time” should sprout it.

https://breakpad.appspot.com/4734002/diff/40001/processor/stackwalk_common.cc
File processor/stackwalk_common.cc (right):

https://breakpad.appspot.com/4734002/diff/40001/processor/stackwalk_common.cc...
processor/stackwalk_common.cc:105: const char* name;
These pointers can be conster.

https://breakpad.appspot.com/4734002/diff/40001/processor/stackwalk_common.cc...
processor/stackwalk_common.cc:312: Register32 data[] = {
These structs should be const.

https://breakpad.appspot.com/4734002/diff/40001/processor/stackwalk_common.cc...
processor/stackwalk_common.cc:326: for (int i = 0; i < 10; ++i) {
Not 10, but arraysize.

https://breakpad.appspot.com/4734002/diff/40001/processor/stackwalk_common.cc...
processor/stackwalk_common.cc:1147: printf("Incident Identifier:
04C9BA62-4E89-4442-9B4D-CD0C77D7D8B9\n");
I’m not happy with these or the hard-coded com.google.chromes. I suggest leaving
them out or adding them in some wrapper script that’s not checked in here. You
can leave placeholder strings like @INCIDENT_ID@ and @BUNDLE_ID@ to easily be
replaced by sed.

https://breakpad.appspot.com/4734002/diff/40001/processor/stackwalk_common.cc...
processor/stackwalk_common.cc:1170: char dateBuf[64];
date_buf

https://breakpad.appspot.com/4734002/diff/40001/processor/stackwalk_common.cc...
processor/stackwalk_common.cc:1173: strftime(dateBuf, 64, "%Y-%m-%d %k:%M:%S.000
%z", crash_time);
sizeof(date_buf)

https://breakpad.appspot.com/4734002/diff/40001/processor/stackwalk_common.cc...
processor/stackwalk_common.cc:1182: // TODO(rohitrao): Add parens around the
build number.
?

Expand All Messages | Collapse All Messages