Issue 4724002: Handle failures of copying process data from a core file. (Closed)
DescriptionHandle failures of copying process data from a core file. When LinuxCoreDumper fails to copy process data from a core file, it fills the return buffer with a repeated sequence of a special marker. However, MinidumpWriter doesn't know about that and may incorrectly interpret the data. In many cases, MinidumpWriter simply copies the gibberish data to the minidump, which isn't too bad. However, the gibberish data may cause MinidumpWriter to behave badly in some other cases. For example, when MinidumpWriter tries to iterate through the linked list of all loaded DSOs via the r_map field of a r_debug struct, if the linked list is filed with the special marker, the code keeps iterating through the same address. This CL addresses the issue by having LinuxCoreDumper::CopyFromProcess() returns a Boolean value to indicate if the expected data is found from the core file. MinidumpWriter can then decide how to handle that. BUG=chromium:453484 TEST=Run core2md with the test data attached to chromium:453484. R=mark@chromium.org Committed: https://code.google.com/p/google-breakpad/source/detail?r=1420 Patch Set 1 #
Total comments: 9
Patch Set 2 : #Patch Set 3 : #
MessagesTotal messages: 10
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
