Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(164)

Issue 457003: processor: add arm exception flags (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by jaysoffian
Modified:
12 years, 2 months ago
Reviewers:
qsr
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

processor: add arm exception flags

From inspection of Apple headers and
https://llvm.org/svn/llvm-project/lldb/trunk/source/Plugins/Process/Utility/S...

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/google_breakpad/common/minidump_exception_mac.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/processor/minidump_processor.cc View 1 2 3 2 chunks +66 lines, -13 lines 0 comments Download

Messages

Total messages: 8
jaysoffian
12 years, 2 months ago #1
jaysoffian
12 years, 2 months ago #2
qsr
LGTM with nits. https://breakpad.appspot.com/457003/diff/4/src/processor/minidump_processor.cc File src/processor/minidump_processor.cc (right): https://breakpad.appspot.com/457003/diff/4/src/processor/minidump_processor.cc#newcode492 src/processor/minidump_processor.cc:492: case MD_EXCEPTION_CODE_MAC_ARM_DA_ALIGN: // 0x0101 You can ...
12 years, 2 months ago #3
jaysoffian
https://breakpad.appspot.com/457003/diff/4/src/processor/minidump_processor.cc File src/processor/minidump_processor.cc (right): https://breakpad.appspot.com/457003/diff/4/src/processor/minidump_processor.cc#newcode492 src/processor/minidump_processor.cc:492: case MD_EXCEPTION_CODE_MAC_ARM_DA_ALIGN: // 0x0101 On 2012/09/24 07:41:54, qsr wrote: ...
12 years, 2 months ago #4
qsr
LGTM again with nits. Do you need me to commit this? https://breakpad.appspot.com/457003/diff/2002/src/processor/minidump_processor.cc File src/processor/minidump_processor.cc (right): ...
12 years, 2 months ago #5
jaysoffian
On 2012/09/24 17:24:28, qsr wrote: > LGTM again with nits. Gah, sorry. Should be fixed ...
12 years, 2 months ago #6
jaysoffian
https://breakpad.appspot.com/457003/diff/2002/src/processor/minidump_processor.cc File src/processor/minidump_processor.cc (right): https://breakpad.appspot.com/457003/diff/2002/src/processor/minidump_processor.cc#newcode492 src/processor/minidump_processor.cc:492: case MD_EXCEPTION_CODE_MAC_ARM_DA_ALIGN: On 2012/09/24 17:24:28, qsr wrote: > I ...
12 years, 2 months ago #7
qsr
12 years, 2 months ago #8
Pushed as revision 1048.

 Can you close this CL? I do not have the right to do it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted