Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(574)

Issue 444002: Add custom getcontext() implementation for Android. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by digit
Modified:
12 years, 2 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add custom getcontext() implementation for Android.

This adds a minimalistic implementation of getcontext()
for Android/ARM and Android/x86. The provided code is
in assembly and only implements the bare minimum required
by Breakpad to get the current processor state.

Note that:

- The FPU state is not saved to the ucontext_t on ARM.
  (that's actually the main difference with a normal
   getcontext() implementation).

  This is normal. On Linux/ARM, such state must be
  obtained with PTRACE_GETVFPREGS instead. This will
  be implemented in a future patch.

- On x86, only the 'regular' FPU state is saved, to
  mimic the GLibc/i386 implementation. The state of
  SSE/SSE2/etc registers is not part of the upstream
  getcontext() implementation.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1024

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 1 3 chunks +10 lines, -0 lines 0 comments Download
M Makefile.in View 1 22 chunks +106 lines, -24 lines 0 comments Download
M aclocal.m4 View 1 1 chunk +22 lines, -0 lines 0 comments Download
M android/google_breakpad/Android.mk View 1 1 chunk +1 line, -0 lines 0 comments Download
M configure View 1 6 chunks +863 lines, -47 lines 0 comments Download
M configure.ac View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/client/linux/handler/exception_handler.cc View 1 3 chunks +3 lines, -9 lines 0 comments Download
A src/common/android/breakpad_getcontext.S View 1 chunk +145 lines, -0 lines 0 comments Download
A src/common/android/breakpad_getcontext_unittest.cc View 1 chunk +76 lines, -0 lines 0 comments Download
M src/common/android/include/sys/ucontext.h View 1 3 chunks +13 lines, -1 line 0 comments Download
M src/common/android/include/ucontext.h View 1 1 chunk +20 lines, -5 lines 0 comments Download
A src/common/android/ucontext_constants.h View 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 4
digit
12 years, 2 months ago #1
Mark Mentovai
LGTM https://breakpad.appspot.com/444002/diff/1/src/common/android/include/ucontext.h File src/common/android/include/ucontext.h (right): https://breakpad.appspot.com/444002/diff/1/src/common/android/include/ucontext.h#newcode46 src/common/android/include/ucontext.h:46: extern int breakpad_getcontext(ucontext_t* ucp); The extern here isn’t ...
12 years, 2 months ago #2
digit
https://breakpad.appspot.com/444002/diff/1/src/common/android/include/ucontext.h File src/common/android/include/ucontext.h (right): https://breakpad.appspot.com/444002/diff/1/src/common/android/include/ucontext.h#newcode46 src/common/android/include/ucontext.h:46: extern int breakpad_getcontext(ucontext_t* ucp); On 2012/08/30 21:31:15, Mark Mentovai ...
12 years, 2 months ago #3
Mark Mentovai
12 years, 2 months ago #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted