Issue 442002: Fix minidump_writer_unittest on Android

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 442002: Fix minidump_writer_unittest on Android (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by digit

Modified:
12 years, 2 months ago

Reviewers:
Mark Mentovai, Ted Mielczarek

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix minidump_writer_unittest on Android

Android doesn't have /bin/cp, so instead do the copy
manually with CopyFile()
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1022

Patch Set 1 #

Total comments: 2

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/linux/minidump_writer/minidump_writer_unittest.cc	View		2 chunks	+3 lines, -4 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Mark Mentovai

12 years, 2 months ago #4

LGTM

https://breakpad.appspot.com/442002/diff/1/src/client/linux/minidump_writer/m...
File src/client/linux/minidump_writer/minidump_writer_unittest.cc (right):

https://breakpad.appspot.com/442002/diff/1/src/client/linux/minidump_writer/m...
src/client/linux/minidump_writer/minidump_writer_unittest.cc:332:
ASSERT_EQ(true, CopyFile(helper_path.c_str(), binpath.c_str())) \
Just ASSERT_TRUE.

Do you need the \ at the end of the line?

https://breakpad.appspot.com/442002/diff/1/src/client/linux/minidump_writer/m...
src/client/linux/minidump_writer/minidump_writer_unittest.cc:333: << "Failed to
copy " << helper_path << " to " << binpath;
Continuation lines get indented by 4, not 2.

Expand All Messages | Collapse All Messages