Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7)

Issue 442002: Fix minidump_writer_unittest on Android (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by digit
Modified:
11 years, 7 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix minidump_writer_unittest on Android

Android doesn't have /bin/cp, so instead do the copy
manually with CopyFile()
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1022

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/linux/minidump_writer/minidump_writer_unittest.cc View 2 chunks +3 lines, -4 lines 2 comments Download

Messages

Total messages: 4
digit
11 years, 7 months ago #1
digit
Sorry, Ted's email was incorrect, I fixed this.
11 years, 7 months ago #2
Ted Mielczarek
LGTM
11 years, 7 months ago #3
Mark Mentovai
11 years, 7 months ago #4
LGTM

https://breakpad.appspot.com/442002/diff/1/src/client/linux/minidump_writer/m...
File src/client/linux/minidump_writer/minidump_writer_unittest.cc (right):

https://breakpad.appspot.com/442002/diff/1/src/client/linux/minidump_writer/m...
src/client/linux/minidump_writer/minidump_writer_unittest.cc:332:
ASSERT_EQ(true, CopyFile(helper_path.c_str(), binpath.c_str())) \
Just ASSERT_TRUE.

Do you need the \ at the end of the line?

https://breakpad.appspot.com/442002/diff/1/src/client/linux/minidump_writer/m...
src/client/linux/minidump_writer/minidump_writer_unittest.cc:333: << "Failed to
copy " << helper_path << " to " << binpath;
Continuation lines get indented by 4, not 2.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted