Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(269)

Issue 441002: Fix 'make check' for Android (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by digit
Modified:
7 years, 3 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix 'make check' for Android

This patch allows 'make check' to work when performing
an Automake-based build of Breakpad for Android. This
requires to have an Android device connected, and the
'adb' tool in your path.

You can test that with something like:

    configure --host=arm-linux-androideabi
    make check

This is achieved by adding a new small shell script
under android/test-shell.sh, which is invoked by the
Makefile (see TESTS_ENVIRONMENT definition in
Makefile.am).

By default, this runs all unit tests, including those
for the processor and tools (which normally never run
on an Android device).

Note that the test suites fails (e.g. 11 failing tests
for the client library). This will be addressed in later
patches.

+ Modify android/run-checks.sh to run the client library
  test suite on the device by default.

+ Add a new option (--all-tests) to android/run-checks.sh
  which forces it to run the unit test suite for the host
  binaries, and the full suite on the Android device.

+ Update README.ANDROID appropriately.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1023

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 1 2 3 3 chunks +8 lines, -2 lines 0 comments Download
M Makefile.in View 1 2 3 13 chunks +48 lines, -3 lines 0 comments Download
M README.ANDROID View 1 2 3 4 chunks +18 lines, -8 lines 0 comments Download
A + android/common-functions.sh View 1 2 3 4 chunks +239 lines, -520 lines 0 comments Download
M android/run-checks.sh View 1 2 3 18 chunks +95 lines, -201 lines 0 comments Download
A android/test-shell.sh View 1 2 3 1 chunk +127 lines, -0 lines 0 comments Download

Messages

Total messages: 4
digit
The latest patch updates test-shell.sh to copy required data files to run tools and processor ...
7 years, 3 months ago #1
Mark Mentovai
LGTM http://breakpad.appspot.com/441002/diff/4001/android/test-shell.sh File android/test-shell.sh (right): http://breakpad.appspot.com/441002/diff/4001/android/test-shell.sh#newcode102 android/test-shell.sh:102: # Count number of connected devices For stuff ...
7 years, 3 months ago #2
digit
http://breakpad.appspot.com/441002/diff/4001/android/test-shell.sh File android/test-shell.sh (right): http://breakpad.appspot.com/441002/diff/4001/android/test-shell.sh#newcode102 android/test-shell.sh:102: # Count number of connected devices On 2012/08/30 21:36:35, ...
7 years, 3 months ago #3
Mark Mentovai
7 years, 3 months ago #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted