Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(546)

Issue 439002: Fix Breakpad unit tests build for Android. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by digit
Modified:
11 years, 7 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix Breakpad unit tests build for Android.

This patch contains the source-related fixes to ensure that
the Breakpad unit tests build properly when targetting Android.

Calling 'make check' still fails because there is still no
way to run the unit test programs on a device. This will be
addressed by a future patch.

Important notes:

- You must target Android API level 9 (Gingerbread) or higher
  to build the unit tests. This requirement is due to the
  current GTest revision used in the breakpad source tree.

- This patch adds headers providing inlined C library functions
  missing from the NDK (see src/common/android/testing). They
  are inlined to avoid modifying Makefile.am and other build
  files.

- Similarly, the <wchar.h> header-fix under
  src/common/android/testing/include is only required by
  GTest's current revision. E.g. it's not needed when building
  Breakpad as part of Chromium which uses a more up-to-date
  revision.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1020

Patch Set 1 #

Total comments: 12

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 2 chunks +12 lines, -2 lines 0 comments Download
M Makefile.in View 7 chunks +36 lines, -24 lines 0 comments Download
A src/common/android/testing/include/wchar.h View 1 1 chunk +72 lines, -0 lines 0 comments Download
A src/common/android/testing/mkdtemp.h View 1 1 chunk +103 lines, -0 lines 0 comments Download
A src/common/android/testing/pthread_fixes.h View 1 chunk +98 lines, -0 lines 0 comments Download
M src/common/linux/elf_core_dump_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/common/linux/tests/crash_generator.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/common/tests/auto_tempdir.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/common/tests/file_utils.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
digit
A quick comments about this patch: - I've decided to use inlined versions of the ...
11 years, 7 months ago #1
Mark Mentovai
http://breakpad.appspot.com/439002/diff/1/src/common/android/testing/include/wchar.h File src/common/android/testing/include/wchar.h (right): http://breakpad.appspot.com/439002/diff/1/src/common/android/testing/include/wchar.h#newcode47 src/common/android/testing/include/wchar.h:47: static wchar_t __inline__ wcstolower(wchar_t ch) { Why __inline__ instead ...
11 years, 7 months ago #2
digit
http://breakpad.appspot.com/439002/diff/1/src/common/android/testing/include/wchar.h File src/common/android/testing/include/wchar.h (right): http://breakpad.appspot.com/439002/diff/1/src/common/android/testing/include/wchar.h#newcode47 src/common/android/testing/include/wchar.h:47: static wchar_t __inline__ wcstolower(wchar_t ch) { Oh, because I ...
11 years, 7 months ago #3
Mark Mentovai
11 years, 7 months ago #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted