Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(271)

Issue 438002: Fix the tools and processor build for Android (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by digit
Modified:
7 years, 3 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix the tools and processor build for Android

This small patch allows the build of the tools and processor
when targetting Android with the Automake/Autconf build.

Not that these necessarily work correctly at the moment,
but there is no need for --disable-tools --disable-processor
now when using --host=arm-linux-androideabi or
--host=i686-linux-android.

+ Modify android/run-checks.sh to build all binaries with
  the Automake build.

+ Tiny fix for --abi=x86 in android/run-checks.sh
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1018

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 6

Patch Set 4 : Fix the tools and processor build for Android #

Patch Set 5 : #

Total comments: 4

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M android/run-checks.sh View 1 2 3 4 3 chunks +15 lines, -10 lines 0 comments Download
M src/client/linux/handler/exception_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/tools/linux/md2core/minidump-2-core.cc View 1 2 3 4 5 7 chunks +48 lines, -3 lines 0 comments Download

Messages

Total messages: 6
digit
I tested that this didn't change the results of the Linux/x86_64 and Linux/x86 test suites. ...
7 years, 3 months ago #1
Mark Mentovai
http://breakpad.appspot.com/438002/diff/4001/android/run-checks.sh File android/run-checks.sh (right): http://breakpad.appspot.com/438002/diff/4001/android/run-checks.sh#newcode490 android/run-checks.sh:490: --host="$GNU_CONFIG" && Alignment (existing problem, but as long as ...
7 years, 3 months ago #2
digit
http://breakpad.appspot.com/438002/diff/4001/android/run-checks.sh File android/run-checks.sh (right): http://breakpad.appspot.com/438002/diff/4001/android/run-checks.sh#newcode490 android/run-checks.sh:490: --host="$GNU_CONFIG" && Done. http://breakpad.appspot.com/438002/diff/4001/src/tools/linux/md2core/minidump-2-core.cc File src/tools/linux/md2core/minidump-2-core.cc (right): http://breakpad.appspot.com/438002/diff/4001/src/tools/linux/md2core/minidump-2-core.cc#newcode205 src/tools/linux/md2core/minidump-2-core.cc:205: ...
7 years, 3 months ago #3
Mark Mentovai
http://breakpad.appspot.com/438002/diff/11001/src/tools/linux/md2core/minidump-2-core.cc File src/tools/linux/md2core/minidump-2-core.cc (right): http://breakpad.appspot.com/438002/diff/11001/src/tools/linux/md2core/minidump-2-core.cc#newcode80 src/tools/linux/md2core/minidump-2-core.cc:80: // platforms. This file-local typedef simplifies the source code. ...
7 years, 3 months ago #4
digit
http://breakpad.appspot.com/438002/diff/11001/src/tools/linux/md2core/minidump-2-core.cc File src/tools/linux/md2core/minidump-2-core.cc (right): http://breakpad.appspot.com/438002/diff/11001/src/tools/linux/md2core/minidump-2-core.cc#newcode80 src/tools/linux/md2core/minidump-2-core.cc:80: // platforms. This file-local typedef simplifies the source code. ...
7 years, 3 months ago #5
Mark Mentovai
7 years, 3 months ago #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted