Issue 433002: Restore Linux ExceptionHandler API + fix Android build.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 433002: Restore Linux ExceptionHandler API + fix Android build. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by digit

Modified:
11 years, 8 months ago

Reviewers:
Mark Mentovai, Ted Mielczarek, jcivelli

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix Android build.

This patch fixes the Android build, and updates the NDK test
application to use the new Linux ExceptionHandler API.

+ Use string insted of std::string in minidump_descriptor.h
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1016

Patch Set 4 : #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	android/google_breakpad/Android.mk	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	android/sample_app/jni/test_breakpad.cpp	View	1 2 3	2 chunks	+6 lines, -4 lines	0 comments	Download
M	src/client/linux/handler/exception_handler.cc	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/client/linux/handler/minidump_descriptor.h	View	1 2 3	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Mark Mentovai

LGTM with one minor formatting change. We didn’t get an e-mail about this one ’til ...

11 years, 8 months ago #2

digit

http://breakpad.appspot.com/433002/diff/1004/android/sample_app/jni/test_breakpad.cpp File android/sample_app/jni/test_breakpad.cpp (right): http://breakpad.appspot.com/433002/diff/1004/android/sample_app/jni/test_breakpad.cpp#newcode53 android/sample_app/jni/test_breakpad.cpp:53: google_breakpad::ExceptionHandler eh(descriptor, NULL, DumpCallback, NULL, true, -1); Done.

11 years, 8 months ago #3

LGTM

Expand All Messages | Collapse All Messages