Clean up warnings about narrowing conversion

Clean up warnings about narrowing conversion

[Jess]

Please review these changes.  These warnings are being treated as errors for
some clients.

[Ben Chan]

http://breakpad.appspot.com/429002/diff/1/src/common/memory_range_unittest.cc
File src/common/memory_range_unittest.cc (right):

http://breakpad.appspot.com/429002/diff/1/src/common/memory_range_unittest.cc...
src/common/memory_range_unittest.cc:58: { false, kBufferSize, ~0UL },
would be it safer to do:

~(size_t)0

instead of assuming size_t is unsigned long?

[Jess]

Excellent point.  Please see patch set 2 for update.

On 2012/08/07 20:09:24, Ben Chan wrote:
> http://breakpad.appspot.com/429002/diff/1/src/common/memory_range_unittest.cc
> File src/common/memory_range_unittest.cc (right):
> 
>
http://breakpad.appspot.com/429002/diff/1/src/common/memory_range_unittest.cc...
> src/common/memory_range_unittest.cc:58: { false, kBufferSize, ~0UL },
> would be it safer to do:
> 
> ~(size_t)0
> 
> instead of assuming size_t is unsigned long?

[Mark Mentovai]

http://breakpad.appspot.com/429002/diff/4001/src/common/memory_range_unittest.cc
File src/common/memory_range_unittest.cc (right):

http://breakpad.appspot.com/429002/diff/4001/src/common/memory_range_unittest...
src/common/memory_range_unittest.cc:58: { false, kBufferSize, ~(size_t)0 },
Use cplusplus<style>(casts), never (c_style)casts.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Castin...

[Mark Mentovai]

http://breakpad.appspot.com/429002/diff/4001/src/common/memory_range_unittest.cc
File src/common/memory_range_unittest.cc (right):

http://breakpad.appspot.com/429002/diff/4001/src/common/memory_range_unittest...
src/common/memory_range_unittest.cc:58: { false, kBufferSize, ~(size_t)0 },
Isn’t -1 more “what I mean,” in which case you’d use -1 casted to size_t?

[Ben Chan]

http://breakpad.appspot.com/429002/diff/4001/src/common/memory_range_unittest.cc
File src/common/memory_range_unittest.cc (right):

http://breakpad.appspot.com/429002/diff/4001/src/common/memory_range_unittest...
src/common/memory_range_unittest.cc:58: { false, kBufferSize, ~(size_t)0 },
On 2012/08/07 20:25:46, Mark Mentovai wrote:
> Isn’t -1 more “what I mean,” in which case you’d use -1 casted to size_t?

yep, static_cast<size_t>(-1) would look better.

[Jess]

I assumed a change proposed to fix a cross tool Werror actually looked at the
surrounding code.  Some day I'll learn.

I agree completely.  In patch set 3.  Thank you for catching these.  Please let
me know if anything else is amiss.

On 2012/08/07 20:25:46, Mark Mentovai wrote:
>
http://breakpad.appspot.com/429002/diff/4001/src/common/memory_range_unittest.cc
> File src/common/memory_range_unittest.cc (right):
> 
>
http://breakpad.appspot.com/429002/diff/4001/src/common/memory_range_unittest...
> src/common/memory_range_unittest.cc:58: { false, kBufferSize, ~(size_t)0 },
> Isn’t -1 more “what I mean,” in which case you’d use -1 casted to size_t?

[Mark Mentovai]

LGTM

[Ben Chan]

On 2012/08/07 20:32:24, Jess wrote:
> I assumed a change proposed to fix a cross tool Werror actually looked at the
> surrounding code.  Some day I'll learn.
> 
> I agree completely.  In patch set 3.  Thank you for catching these.  Please
let
> me know if anything else is amiss.
> 
> On 2012/08/07 20:25:46, Mark Mentovai wrote:
> >
>
http://breakpad.appspot.com/429002/diff/4001/src/common/memory_range_unittest.cc
> > File src/common/memory_range_unittest.cc (right):
> > 
> >
>
http://breakpad.appspot.com/429002/diff/4001/src/common/memory_range_unittest...
> > src/common/memory_range_unittest.cc:58: { false, kBufferSize, ~(size_t)0 },
> > Isn’t -1 more “what I mean,” in which case you’d use -1 casted to size_t?

lgtm. thanks for fixing it

[Jess]

Checked in at r1006.