Improve Android support + Fix Android/x86 build.

Improve Android support

This patch remove many Android-specific #ifdefs from the Breakpad
source code. This is achieved by providing "fixed-up" platform
headers (e.g. <signal.h> or <sys/user,h>), in the new directory
src/common/android/include/, which masks differences between
the NDK and GLibc headers.

The old "android_link.h" and "android_ucontext.h" are moved
and renamed.

This also requires putting this directory as the first
include path during Android-hosted builds, hence the
modification of Makefile.am and configure.ac

[digit]

Note that I'm well aware that this is a complex patch. There are probably many
ways to do this differently, but I think that removing Android-specific special
case from the main source is worth it.

[Mark Mentovai]

http://breakpad.appspot.com/427004/diff/1/android/run-checks.sh
File android/run-checks.sh (right):

http://breakpad.appspot.com/427004/diff/1/android/run-checks.sh#newcode466
android/run-checks.sh:466: x86) GNU_CONFIG=i686-linux-android;;
This is fine (and simple) but I’d still break this up into a separate change.

http://breakpad.appspot.com/427004/diff/1/configure.ac
File configure.ac (right):

http://breakpad.appspot.com/427004/diff/1/configure.ac#newcode65
configure.ac:65: *-android*)
I see that you copied this from the Linux block above, but the indentation here
is very odd.

http://breakpad.appspot.com/427004/diff/1/configure.ac#newcode66
configure.ac:66: ANDROID_HOST=true
Less odd here than on the line that sets LINUX_HOST above, though.

http://breakpad.appspot.com/427004/diff/1/src/common/android/include/link.h
File src/common/android/include/link.h (right):

http://breakpad.appspot.com/427004/diff/1/src/common/android/include/link.h#n...
src/common/android/include/link.h:1: #ifndef
GOOGLE_BREAKPAD_ANDROID_INCLUDE_LINK_H
License boilerplate?

http://breakpad.appspot.com/427004/diff/1/src/common/android/include/link.h#n...
src/common/android/include/link.h:1: #ifndef
GOOGLE_BREAKPAD_ANDROID_INCLUDE_LINK_H
Missing a COMMON in here.

http://breakpad.appspot.com/427004/diff/1/src/common/android/include/link.h#n...
src/common/android/include/link.h:2: #define
GOOGLE_BREAKPAD_ANDROID_INCLUDE_LINK_H
This file doesn’t show up as a copy of the old src/client/linux/android_link.h
but it probably should since it’s got the same function.

src/common/android/include/sys/ucontext.h did show up as a copy.

[digit]

http://breakpad.appspot.com/427004/diff/1/android/run-checks.sh
File android/run-checks.sh (right):

http://breakpad.appspot.com/427004/diff/1/android/run-checks.sh#newcode466
android/run-checks.sh:466: x86) GNU_CONFIG=i686-linux-android;;
Thanks, indeed, this patch is already too large.

http://breakpad.appspot.com/427004/diff/1/configure.ac
File configure.ac (right):

http://breakpad.appspot.com/427004/diff/1/configure.ac#newcode66
configure.ac:66: ANDROID_HOST=true
On 2012/08/15 17:00:50, Mark Mentovai wrote:
> Less odd here than on the line that sets LINUX_HOST above, though.
Ok, I'll try to fix both then.

[digit]

Hummm. I'm sorry, this patch depends on / includes fixes from
http://breakpad.appspot.com/427004/. I have used --base_url with gcl upload but
it looks like the issue was not updated. I'll create a new one to resolve this.

[digit]

I'm closing this bug. The real fix is now in http://breakpad.appspot.com/434002/