Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(270)

Issue 424002: android: Add --abi option to android/run-checks.sh (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by digit
Modified:
7 years, 4 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

android: Add --abi option to android/run-checks.sh

This patch adds an option to android/run-checks.sh to specify
the target ABI. For example, by using the following line:

  android/run-checks.sh --abi=x86 --no-device

One can check the Android/x86 build of Google Breakpad (which
still fails for reasons that will be fixed in later patches).

Another use is to force the 'armeabi' ABI even when an
ARMv7-A device is connected (which uses the 'armeabi-v7a'
by default, but supports 'armeabi' as well).
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1003

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M android/google_breakpad/Android.mk View 1 1 chunk +2 lines, -2 lines 0 comments Download
M android/run-checks.sh View 1 2 6 chunks +65 lines, -11 lines 0 comments Download

Messages

Total messages: 7
digit
friendly ping?
7 years, 4 months ago #1
Ted Mielczarek
LGTM http://breakpad.appspot.com/424002/diff/1/android/run-checks.sh File android/run-checks.sh (right): http://breakpad.appspot.com/424002/diff/1/android/run-checks.sh#newcode178 android/run-checks.sh:178: --abi=<name> Specify target CPU ABI [auto-detected]. You should ...
7 years, 4 months ago #2
Mark Mentovai
LGTM. I agree with Ted’s comments.
7 years, 4 months ago #3
Mark Mentovai
Also note that the first message I saw from you on this code review was ...
7 years, 4 months ago #4
digit
Thanks. I've uploaded a new patch which includes full documentation for --abi, including the list ...
7 years, 4 months ago #5
Mark Mentovai
LGTM http://breakpad.appspot.com/424002/diff/7001/android/run-checks.sh File android/run-checks.sh (right): http://breakpad.appspot.com/424002/diff/7001/android/run-checks.sh#newcode182 android/run-checks.sh:182: The parameter for --abi must be one of ...
7 years, 4 months ago #6
Ted Mielczarek
7 years, 4 months ago #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted