android: Add --abi option to android/run-checks.sh

android: Add --abi option to android/run-checks.sh

This patch adds an option to android/run-checks.sh to specify
the target ABI. For example, by using the following line:

  android/run-checks.sh --abi=x86 --no-device

One can check the Android/x86 build of Google Breakpad (which
still fails for reasons that will be fixed in later patches).

Another use is to force the 'armeabi' ABI even when an
ARMv7-A device is connected (which uses the 'armeabi-v7a'
by default, but supports 'armeabi' as well).
Committed: https://code.google.com/p/google-breakpad/source/detail?r=1003

[digit]

friendly ping?

[Ted Mielczarek]

LGTM

http://breakpad.appspot.com/424002/diff/1/android/run-checks.sh
File android/run-checks.sh (right):

http://breakpad.appspot.com/424002/diff/1/android/run-checks.sh#newcode178
android/run-checks.sh:178: --abi=<name>     Specify target CPU ABI
[auto-detected].
You should probably list the valid options here.

http://breakpad.appspot.com/424002/diff/1/android/run-checks.sh#newcode417
android/run-checks.sh:417: dump "Using CPU ABI: $ABI (device + command-line)"
nit: I'd just say (command-line) here.

[Mark Mentovai]

LGTM. I agree with Ted’s comments.

[Mark Mentovai]

Also note that the first message I saw from you on this code review was your
friendly ping, although it looks like you uploaded the patch set 3 days ago.
Rietveld is sometimes untrustworthy like that. :(

[digit]

Thanks. I've uploaded a new patch which includes full documentation for --abi,
including the list of valid values. Can I ask you to have a quick glance at it
(just the difference between the first and second patchset should be enough).

[Mark Mentovai]

LGTM

http://breakpad.appspot.com/424002/diff/7001/android/run-checks.sh
File android/run-checks.sh (right):

http://breakpad.appspot.com/424002/diff/7001/android/run-checks.sh#newcode182
android/run-checks.sh:182: The parameter for --abi must be one of the following:
$VALID_ABIS
I’d put VALID_ABIS on its own line because as it stands now, this is the only
line of the help message that’s gonna wrap.

[Ted Mielczarek]

LGTM