Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(66)

Issue 417002: minidump-2-core: Output all memory regions to core file

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by Michael Krebs
Modified:
12 years, 4 months ago
Reviewers:
markus
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

minidump-2-core: Output all memory regions to core file

Most memory regions are already output to the core file due to the rest of
the minidump, but the region where the actual crashing PC is not.  The
backtrace command in gdb tries to disassemble the first function in the
stack trace, and if it can't then it assumes that there's no stack frame and
can end up walking up the stack incorrectly.

This change will output all the memory regions from the minidump.  Note that
AddDataToMapping() already handles overlapping regions, so this should only
result in the one extra region.

BUG=chromium-os:32626
TEST=Ran unittests

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/tools/linux/md2core/minidump-2-core.cc View 1 4 chunks +44 lines, -0 lines 0 comments Download

Messages

Total messages: 1
Michael Krebs
12 years, 4 months ago #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted