Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8691)

Issue 412002: Fix compilation directive for PPC. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by qsr
Modified:
11 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

 Fix compilation for iOS on XCode 4.5

 Compilation directive for PPC was using MAC_OS_X_VERSION_MIN_REQUIRED.

 This is not correct, as the latest SDKs allow to compile for older version of
Mac OS, but don't contain the ppc headers. Changing the directive to use
MAC_OS_X_VERSION_MAX_ALLOWED instead.

 Moreover, uploader.mm was including pwd.h that was not used and doesn't exist
on the latest iOS SDK.
Committed: https://code.google.com/p/google-breakpad/source/detail?r=982

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/mac/handler/minidump_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/client/mac/sender/uploader.mm View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2
qsr
11 years, 8 months ago #1
Mark Mentovai
11 years, 8 months ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted