Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(268)

Issue 407002: Add Android NDK module definition + sample application (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 5 months ago by digit
Modified:
7 years, 4 months ago
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add Android NDK module definition + sample application

This patch adds a new directory named "android/" which contains
the following:

- A NDK build system module definition for the Google Breakpad
  client library. This can be used by developers using the ndk-build
  build system to more easily build and use the client library in
  their own programs.

- A sample application demonstrating how to use the module,
  as well as test that the library works properly during a
  crash.

- A shell script (run-checks.sh) that will check everything
  for you automatically, including:

  - Rebuilding the host Google Breakpad host package with configure/make
  - Rebuilding the Android client library with configure/make
  - Rebuilding the Android client library and test program with ndk-build
  - Running the crashing test program, extract minidump, dump symbols,
    generate a stack trace and check that it has correct source file
    locations.

For more details, run android/run-checks.sh --help-all

+ Updates to the README.ANDROID documentation.

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 19

Patch Set 5 : #

Total comments: 46

Patch Set 6 : #

Patch Set 7 : #

Total comments: 3

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
A README.ANDROID View 1 2 3 4 5 1 chunk +134 lines, -0 lines 0 comments Download
A android/google_breakpad/Android.mk View 1 2 3 4 5 1 chunk +96 lines, -0 lines 0 comments Download
A android/run-checks.sh View 1 2 3 4 5 6 7 8 1 chunk +594 lines, -0 lines 0 comments Download
A android/sample_app/README View 1 chunk +32 lines, -0 lines 0 comments Download
A android/sample_app/jni/Android.mk View 1 2 3 4 5 1 chunk +44 lines, -0 lines 0 comments Download
A android/sample_app/jni/Application.mk View 1 chunk +31 lines, -0 lines 0 comments Download
A android/sample_app/jni/test_breakpad.cpp View 1 2 3 4 5 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 16
digit
NOTE: You need to apply either 393002+393003 or 402002+403002+404002 to ensure that the run-test-program.sh script ...
7 years, 5 months ago #1
digit
Small correction, on a 64-bit host machine, you can use the --enable-m32 option to run-test-program.sh ...
7 years, 5 months ago #2
Mark Mentovai
http://breakpad.appspot.com/407002/diff/6001/README.ANDROID File README.ANDROID (right): http://breakpad.appspot.com/407002/diff/6001/README.ANDROID#newcode4 README.ANDROID:4: The Google Breakpad client library can now be used ...
7 years, 5 months ago #3
digit
http://breakpad.appspot.com/407002/diff/6001/README.ANDROID File README.ANDROID (right): http://breakpad.appspot.com/407002/diff/6001/README.ANDROID#newcode4 README.ANDROID:4: The Google Breakpad client library can now be used ...
7 years, 5 months ago #4
Mark Mentovai
I was trying to avoid reading a new long file. It’s OK if nobody’s reviewed ...
7 years, 5 months ago #5
Mark Mentovai
http://breakpad.appspot.com/407002/diff/6001/README.ANDROID File README.ANDROID (right): http://breakpad.appspot.com/407002/diff/6001/README.ANDROID#newcode132 README.ANDROID:132: Get rid of the blank line at EOF. Same ...
7 years, 5 months ago #6
digit
http://breakpad.appspot.com/407002/diff/6001/android/sample_app/jni/test_breakpad.cpp File android/sample_app/jni/test_breakpad.cpp (right): http://breakpad.appspot.com/407002/diff/6001/android/sample_app/jni/test_breakpad.cpp#newcode33 android/sample_app/jni/test_breakpad.cpp:33: static bool dumpCallback(const char* dump_path, This was taken from ...
7 years, 5 months ago #7
Mark Mentovai
http://breakpad.appspot.com/407002/diff/1009/android/run-test-program.sh File android/run-test-program.sh (right): http://breakpad.appspot.com/407002/diff/1009/android/run-test-program.sh#newcode231 android/run-test-program.sh:231: TMPDIR=/tmp/$PROGNAME-$USER digit wrote: > On 2012/07/02 16:50:13, Mark Mentovai ...
7 years, 5 months ago #8
digit
On 2012/07/03 13:03:58, Mark Mentovai wrote: > > trap is not a bash-ism, it’s standard ...
7 years, 5 months ago #9
digit
The latest patch should fix the stylistic issues. The temporary directory is now created with ...
7 years, 5 months ago #10
Mark Mentovai
http://breakpad.appspot.com/407002/diff/13002/android/run-test-program.sh File android/run-test-program.sh (right): http://breakpad.appspot.com/407002/diff/13002/android/run-test-program.sh#newcode265 android/run-test-program.sh:265: TMPDIR=$(mktemp -d) This won’t work on Macs. Two problems: ...
7 years, 5 months ago #11
Mark Mentovai
7 years, 5 months ago #12
digit
By the way, I'd like to rename the script from run-test-program.sh to something different (it ...
7 years, 5 months ago #13
Mark Mentovai
That's fine. Maybe run-checks-on-device.sh? On Jul 4, 2012 8:59 AM, <digit@chromium.org> wrote: > By the ...
7 years, 5 months ago #14
digit
I'm going with run-checks.sh now. The script actually spend most of its time rebuilding Breakpad ...
7 years, 5 months ago #15
Mark Mentovai
7 years, 5 months ago #16
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted