Issue 398002: Fix a race condition in AutoCriticalSection.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 398002: Fix a race condition in AutoCriticalSection. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by Lei Zhang (chromium)

Modified:
13 years ago

Reviewers:
alexeypa, Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix a race condition in AutoCriticalSection.

CID=104232
Committed: https://code.google.com/p/google-breakpad/source/detail?r=972

Patch Set 1 #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/client/windows/common/auto_critical_section.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

alexeypa

LGTM though AutoCriticalSection is supposed to be thread-local so it should not matter that the ...

13 years ago #3

Lei Zhang (chromium)

13 years ago #4

On 2012/06/18 23:53:35, alexeypa wrote:
> LGTM though AutoCriticalSection is supposed to be thread-local so it should
not
> matter that the flag is cleared outside of the critical section. Have anything
> broke? In any case this CL make things better...

Nothing broke AFAIK. The Coverity static analysis tool is complaining though.

Expand All Messages | Collapse All Messages