Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1780)

Issue 398002: Fix a race condition in AutoCriticalSection. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by Lei Zhang (chromium)
Modified:
13 years ago
Reviewers:
alexeypa, Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix a race condition in AutoCriticalSection.

CID=104232
Committed: https://code.google.com/p/google-breakpad/source/detail?r=972

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/windows/common/auto_critical_section.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
Lei Zhang (chromium)
13 years ago #1
Mark Mentovai
LGTM
13 years ago #2
alexeypa
LGTM though AutoCriticalSection is supposed to be thread-local so it should not matter that the ...
13 years ago #3
Lei Zhang (chromium)
13 years ago #4
On 2012/06/18 23:53:35, alexeypa wrote:
> LGTM though AutoCriticalSection is supposed to be thread-local so it should
not
> matter that the flag is cleared outside of the critical section. Have anything
> broke? In any case this CL make things better...

Nothing broke AFAIK. The Coverity static analysis tool is complaining though.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted